feat:mget supports cache querying multiple keys #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chejinge
force-pushed
the
multi_get
branch
4 times, most recently
from
fe7bdab
to
518171e
Compare
chejinge
changed the title
chejinge
force-pushed
the
multi_get
branch
2 times, most recently
from
759d335
to
b855371
Compare
AlexStocks
reviewed
May 28, 2024
baixin01
reviewed
Jun 3, 2024
baixin01
reviewed
Jun 3, 2024
baixin01
approved these changes
Jun 3, 2024
cheniujh
reviewed
Jun 3, 2024
cheniujh
approved these changes
Jun 3, 2024
wangshao1
approved these changes
Jun 3, 2024
AlexStocks
reviewed
Jun 3, 2024
AlexStocks
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2612
1.这个PR主要添加上述issue的feat:
查询方式，先查询cache，记录未命中的key，有一个未命中去DB中查询，查到后进行组装
2.bug 修复1:当flushdb后disablecacheflag导致cache不能继续使用
3.bug修复2:修复cache存feild个数限制时候不需要设置disable flag
4.之前的测试因为需要flushdb ，因此会导致测试的时候cache根本就没开，本次开启后发现 redis4.0和pika因为bitpos和bitget命令实现方式不一致 导致有些TCL边界测试用例通不过，暂时将这两个命令的flag关闭，待升级后一并打开